Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removed duplicate attr_accessor #1352

Closed
wants to merge 1 commit into from
Closed

Removed duplicate attr_accessor #1352

wants to merge 1 commit into from

Conversation

docwhat
Copy link
Contributor

@docwhat docwhat commented Aug 16, 2014

Sitemap::Resource had a duplicate attr_accessor for destination_path

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.04%) when pulling 49fa79b on docwhat:docwhat-dupaccessor into 345cbdc on middleman:v3-stable.

@docwhat
Copy link
Contributor Author

docwhat commented Aug 16, 2014

I'm not sure why Travis failed... It passes for me on my system.

@tdreyno
Copy link
Member

tdreyno commented Aug 17, 2014

Looks like all our tests may be failing with the new compass v1 release on Friday. No bugs, just different hashing out output.

@tdreyno
Copy link
Member

tdreyno commented Aug 17, 2014

Fixed our tests. Can you rebase?

@docwhat
Copy link
Contributor Author

docwhat commented Aug 20, 2014

@tdreyno done.

Sitemap::Resource had a duplicate `attr_accessor` for `destination_path`
@coveralls
Copy link

Coverage Status

Coverage increased (+0.12%) when pulling 53f2a2a on docwhat:docwhat-dupaccessor into 51d57af on middleman:v3-stable.

@tdreyno tdreyno closed this in 0d2bcba Aug 20, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants