Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not create unnecessary array in IgnoreDescriptor #2183

Merged
merged 3 commits into from Sep 10, 2018

Conversation

Projects
None yet
2 participants
@TheSmartnik
Copy link
Contributor

TheSmartnik commented Aug 7, 2018

Hi,
I was investigating some memory problems in my middleman project and found this piece of code. As ignore! mutates original object, seems unnecessary to create another array with map, each will do the same thing here without extra allocation

@tdreyno

This comment has been minimized.

Copy link
Member

tdreyno commented Aug 12, 2018

Looks good. Will merge after we fix Travis

tdreyno added some commits Sep 10, 2018

@tdreyno tdreyno merged commit 6db5021 into middleman:master Sep 10, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.