Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Unpin ActiveSupport #2324

Merged
merged 2 commits into from May 19, 2020
Merged

Unpin ActiveSupport #2324

merged 2 commits into from May 19, 2020

Conversation

brettmortensen
Copy link

Unpins ActiveSupport for compatibility with Rails 6.

@brettmortensen
Unpin ActiveSupport
814c594 
Unpins ActiveSupport for compatibility with Rails 6.
tdreyno
tdreyno requested changes May 19, 2020
View reviewed changes
Copy link
Member

@tdreyno tdreyno left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

probably safer to be a range between 5 and 6... because 4 will definitely break

@brettmortensen
Use range for ActiveSupport gem
6a1ef20 
Allows range of ActiveSupport between 5 and 6.
@brettmortensen
Copy link
Author

Thanks @tdreyno for the quick review. Just updated 👍

@tdreyno tdreyno merged commit 4cf8478 into middleman:master May 19, 2020
@tnir tnir mentioned this pull request Apr 10, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tdreyno tdreyno tdreyno approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@brettmortensen @tdreyno