sitemap/traversal: Use compiled regex for performance improvement

[davebarrau]

I found when building a large site (Gitlab's Handbook) with a lot of pages, the flame graph was getting stuck quite a bit in the @store.resources.find block in sitemap/extensions/traversal.rb.

With the change in this MR I was able to decrease the build time from ~3m30s to ~2m20s, a ~33% saving for this specific use case.

[tdreyno]

Fantastic find. Thank you.

[davebarrau]

Fantastic find. Thank you.

No worries! Looks like the ubuntu-ruby-2.4 check got stuck or failed to report in. Can you re-run it?

[davebarrau]

@tdreyno Hi Thomas! Thanks again for merging this. Is it possible to release a 4.4.1 with this PR in it? :) Or, when do you expect the next release to land?

[tdreyno]

Done

[davebarrau]

Done

Thanks @tdreyno! I think the gem might have the same issue 4.3.9 had (filesize 4.5 KB rather than 5.5 KB):

4.4.1 - November 02, 2021 (4.5 KB)
4.4.0 - June 16, 2021 (5.5 KB)
4.3.11 - September 15, 2020 (5.5 KB)
4.3.10 - September 10, 2020 (5.5 KB)
4.3.9 - September 09, 2020 (4.5 KB) yanked

Apologies for being a pain!

[tdreyno]

Fixed. Forgot that my windows machine is borked for gem pushing