sitemap/traversal: Use compiled regex for performance improvement #2502
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Fantastic find. Thank you. |
No worries! Looks like the ubuntu-ruby-2.4 check got stuck or failed to report in. Can you re-run it? |
|
@tdreyno Hi Thomas! Thanks again for merging this. Is it possible to release a 4.4.1 with this PR in it? :) Or, when do you expect the next release to land? |
|
Done |
Thanks @tdreyno! I think the gem might have the same issue 4.3.9 had (filesize 4.5 KB rather than 5.5 KB): Apologies for being a pain! |
|
Fixed. Forgot that my windows machine is borked for gem pushing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I found when building a large site (Gitlab's Handbook) with a lot of pages, the flame graph was getting stuck quite a bit in the
@store.resources.findblock insitemap/extensions/traversal.rb.With the change in this MR I was able to decrease the build time from ~3m30s to ~2m20s, a ~33% saving for this specific use case.