fix: fixed branch selector #415
Conversation
|
Thanks for both of your PRs, @ayush3160 |
|
Hey @ayush3160 . Thanks for the contribution! Pulled your PR for testing, this behaviour seems incorrect. Custom branch names should render only if custom branches are selected, other wise the 
Here, no custom branches were selected, yet the input is filled. This can be fixed by checking if prod-branches or all-branches are selected. if yes, then the state for the input must be empty. feel free to ask more questions, we'll be glad to help! |
|
Hi @e-for-eshaan , Thanks for reviewing I missed the case of prod and all branches mode but I have fixed it in above commit please have a look and let me know if any other changes are needed. |
| ) | ||
| } | ||
| ); | ||
| depFn(localBranchNames.set, []); |
There was a problem hiding this comment.
localBranchNames.set should be included in the dependency array of the setProdStateBranchNames callback
|
Hey @ayush3160 ! Sorry for the late response, but your PR looks promising, just tested it locally. |
|
Thanks for reviewing @e-for-eshaan , I have done the changes please check once. |
Branch names now are rendering as removable-chips after reloading page.
Linked Issue(s)
fixes #331
Proposed changes (including videos or screenshots)
2024-06-04.18-45-50.mp4