Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Limit access for Database and Backend Servers for developer environment" #436

Merged
merged 1 commit into from
Jun 18, 2024

Conversation

adnanhashmi09
Copy link
Contributor

Reverts #376

This PR is being reverted because the ports are not being mapped to the host machine. This is because the container's network stack is isolated from the host machine. So accessing container's localhost from the host is not possible.

We can keep the network stack of container isolated and allow all access on 0.0.0.0 and then we could map to only 127.0.0.1 when mapping the port

@adnanhashmi09 adnanhashmi09 merged commit b3b9712 into main Jun 18, 2024
1 check passed
@adnanhashmi09 adnanhashmi09 deleted the revert-376-limit-access branch June 18, 2024 12:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants