Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add correct ports in the cli ui and give child processes access to env variables #438

Merged
merged 1 commit into from
Jun 18, 2024

Conversation

adnanhashmi09
Copy link
Contributor

@adnanhashmi09 adnanhashmi09 commented Jun 18, 2024

  1. Update the TUI to include correct ports and hosts from the environment variables of respective services.
  2. Put the environment variables of parent process into the context of child process

@adnanhashmi09 adnanhashmi09 changed the title Add correct ports in the cli ui Add correct ports in the cli ui and give child processes access to env variables Jun 18, 2024
Copy link
Contributor

@samad-yar-khan samad-yar-khan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm

@adnanhashmi09 adnanhashmi09 merged commit 8c314eb into main Jun 18, 2024
1 check passed
@adnanhashmi09 adnanhashmi09 deleted the port-env-access-cli branch June 18, 2024 14:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants