Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ability to apply plugins to middy/validator #550

Closed
leoglobant opened this issue Aug 13, 2020 · 4 comments · Fixed by #552
Closed

Ability to apply plugins to middy/validator #550

leoglobant opened this issue Aug 13, 2020 · 4 comments · Fixed by #552

Comments

@leoglobant
Copy link

leoglobant commented Aug 13, 2020

(Thanks for reporting an issue! Please make sure you click the link above to view the issue guidelines, then fill out the blanks below.)

What are the steps to reproduce this issue?

N/A

What happens?

In order to better customize middy/validator to show up custom errors, I need to apply this plugin: https://github.com/ajv-validator/ajv-errors

What were you expecting to happen?

Ability apply plugins to validator ajv instance.

Any logs, error output, etc?

N/A

Any other comments?

Thanks!

What versions of software are you using?

N/A

@willfarrell
Copy link
Member

Would you be willing to create a PR? I'm open to extending the current one to add support for aj-errors or your proposed solution.

@leoglobant
Copy link
Author

Sure, I can try at least. I will find time to contribute. Would it be OK if I use this issue to ask question in case I have while giving it a try?

@willfarrell
Copy link
Member

Of course.

@leoglobant leoglobant changed the title Ability to pass ajv instance to middy/validator Ability to apply plugins to middy/validator Aug 15, 2020
@leog
Copy link
Contributor

leog commented Aug 15, 2020

BTW I'm @leoglobant as well, didn't noticed I was using my work related account to create the issue 😅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging a pull request may close this issue.

3 participants