-
-
Notifications
You must be signed in to change notification settings - Fork 375
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New Middleware Proposal: S3 #594
Comments
@iDVB I was thinking of your middleware could benefit from this. Allow it to be simpler. |
thanks @willfarrell this would be great. I think there would have to be some control on caching as well. Right now I'd be interested in talking more or helping out with this. |
I was thinking it would look just like this, just with s3. https://github.com/middyjs/middy/tree/release/2.x/packages/ssm |
Yup, that looks about right. Just a thought. This would only work with one of my S3 calls for my default config file. However, there are other "conditional" calls for 404.html etc that would likely still benefit from being baked into my middleware. |
How the aws middlewares are structured now support multiple requests based on a key mapping. There is no fetch only when needed. Let prefetch request everything you do need, resolve only what you need when you need it. There is an new |
Closing, been year without enough interest. |
Sorry @willfarrell, been super busy on a number of things. This still sounds interesting to me. Is this still something that applys? |
Re-opening based on a comment from the powertools team (#948 (comment)). |
I've created PR #961 for this. Please feel free to comment or contribute types. |
Proposal for a new S3 middleware that could pull string or json from a file in S3 and store to internal.
See ssm for what it could look like: https://github.com/middyjs/middy/tree/main/packages/ssm
Please 👍🏻 this issue if it would have value to you. I'll build it if there > 10 👍🏻
If you can comment with your use case below, that would be helpful.
The text was updated successfully, but these errors were encountered: