Adds normalizeHttpEvent Middleware #101
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #101 +/- ##
=====================================
Coverage 100% 100%
=====================================
Files 14 15 +1
Lines 261 267 +6
Branches 48 51 +3
=====================================
+ Hits 261 267 +6
Continue to review full report at Codecov.
|
lmammino
requested changes
Jan 24, 2018
lmammino
requested changes
Jan 24, 2018
There was a problem hiding this comment.
Fantastic.
Only 2 things before this can be ready for the merge:
- I would rename
withDefaultHttpEventtonormalizeHttpEvent(see Api Gateway proxy event normalizer middleware #35) - We need middleware docs for
normalizeHttpEvent(see https://github.com/middyjs/middy/blob/master/docs/middlewares.md) and update the list of middlewares accordingly in the README.md.hb
|
Hey @i-am-kenny, are you ok with the above comment? Do you need any kind of help/support? |
lmammino
changed the title
lmammino
approved these changes
Jan 28, 2018
|
Merged, thanks for your precious contribution @i-am-kenny 😉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should allow the CORS header to be applied even if the request fails. I can easily add the other headers/tests, but I wasn't sure about some reasonable defaults.
Closes #35