Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add caching to the SSM middleware #107

Merged
merged 6 commits into from Feb 1, 2018
Merged

Add caching to the SSM middleware #107

merged 6 commits into from Feb 1, 2018

Conversation

vladholubiev
Copy link
Contributor

Can't believe I forgot this in the initial implementation

@codecov
Copy link

codecov bot commented Feb 1, 2018

Codecov Report

Merging #107 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@          Coverage Diff          @@
##           master   #107   +/-   ##
=====================================
  Coverage     100%   100%           
=====================================
  Files          16     16           
  Lines         293    303   +10     
  Branches       57     61    +4     
=====================================
+ Hits          293    303   +10
Impacted Files Coverage Δ
src/middlewares/ssm.js 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update be4179e...eb81af8. Read the comment docs.

Copy link
Member

@lmammino lmammino left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sounds awesome! Can you make sure to increase the coverage to make the coverage test pass?

Aside from that I'b be happy with the changes

@vladholubiev
Copy link
Contributor Author

@lmammino sure, back to 💯 again!

Copy link
Member

@lmammino lmammino left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome, I'll version bump and get this published

@vladholubiev
Copy link
Contributor Author

@lmammino ⚡️ fast, thanks!

@lmammino lmammino merged commit 7a2286d into middyjs:master Feb 1, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants