fix: httpErrorHandler minification type checking

[chrisandrews7]

If the code is mangled during minification process when using webpack, the check for a type of HttpError in the httpErrorHandler middleware will fail. As the private property on super_.name will not be HttpError, the mangling would change the name.

This is due to Terser setting both keep_classnames and keep_fnames to false by default.
Either way it shouldn't really use a private property to check the type of error.

This will close #325

[codecov]

Codecov Report

Merging #337 into master will not change coverage.
The diff coverage is 100%.

@@          Coverage Diff          @@
##           master   #337   +/-   ##
=====================================
  Coverage     100%   100%           
=====================================
  Files          20     20           
  Lines         542    543    +1     
  Branches      110    110           
=====================================
+ Hits          542    543    +1

Impacted Files	Coverage Δ
src/middlewares/httpErrorHandler.js	100% <100%> (ø)	⬆️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7fdee78...2e7cf81. Read the comment docs.

[codecov]

Codecov Report

Merging #337 into master will not change coverage.
The diff coverage is 100%.

@@          Coverage Diff          @@
##           master   #337   +/-   ##
=====================================
  Coverage     100%   100%           
=====================================
  Files          20     20           
  Lines         543    543           
  Branches      111    111           
=====================================
  Hits          543    543

Impacted Files	Coverage Δ
src/middlewares/httpErrorHandler.js	100% <100%> (ø)	⬆️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b8af685...01409e6. Read the comment docs.

[chrisandrews7]

This cant be merged until both jshttp/http-errors#56 and npm/npm#19770 have been resolved. I guess thats why it was done in the current way.

[chrisandrews7]

Given the only thing used by the response is statusCode. Could do a check on the handler.error.statusCode property as the type identifier in the meantime? @lmammino @dkatavic @theburningmonk @vladgolubev

[lmammino]

Seems good, thanks @chrisandrews7!

I initially didn't like the solution to check the statusCode (I was more inclined to a check like instanceof HttError), but after thinking a bit more about it, I think it's simple enough and it might work in most cases, even if a custom middleware doesn't want to return an actual instance of HttpError.

I'll try to get this merged shortly, can you submit the same change for v1.0.0-alpha? :)

[lmammino]

I actually added an extra check for message as well, added a dedicated test case and updated the docs.

I think I have enough time to forward port this to 1.0.0