Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix/rename on error middleware #4

Merged
merged 3 commits into from Aug 14, 2017
Merged

Fix/rename on error middleware #4

merged 3 commits into from Aug 14, 2017

Conversation

dkatavic
Copy link
Contributor

Close #3

@dkatavic dkatavic self-assigned this Aug 14, 2017
@dkatavic dkatavic requested a review from lmammino August 14, 2017 09:36
@dkatavic
Copy link
Contributor Author

Also Close #2

lmammino
lmammino approved these changes Aug 14, 2017
View reviewed changes
Copy link
Member

@lmammino lmammino left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution! Looks great! :)

Feel free to merge it yourself!

package.json
@@ -18,7 +19,7 @@
"Serverless",
"Framework"
],
"author": "Luciano Mammino, Peter Caulfield, Joe Minichino",
"author": "Luciano Mammino, Peter Caulfield, Joe Minichino, Domagoj Katavic",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 this is the most important change! :)

@dkatavic dkatavic merged commit ff78dfc into master Aug 14, 2017
@dkatavic dkatavic deleted the fix/renameOnErrorMiddleware branch August 14, 2017 09:58
@dkatavic dkatavic mentioned this pull request Aug 14, 2017
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lmammino lmammino lmammino approved these changes

Assignees

@dkatavic dkatavic

Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@dkatavic @lmammino