Support for async/await #51
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lmammino
requested review from
peterjcaulfield,
padraigobrien,
techfort,
acambas and
dkatavic
Codecov Report
@@ Coverage Diff @@
## master #51 +/- ##
=====================================
Coverage 100% 100%
=====================================
Files 9 10 +1
Lines 142 157 +15
Branches 31 36 +5
=====================================
+ Hits 142 157 +15
Continue to review full report at Codecov.
|
|
This is now ready for review, please have a look and let me know what you think! CC: @acambas @techfort @peterjcaulfield @padraigobrien @dkatavic |
dkatavic
approved these changes
Nov 19, 2017
src/middy.js
Outdated
| @@ -79,7 +93,23 @@ const runErrorMiddlewares = (middlewares, instance, done) => { | |||
| const nextMiddleware = stack.shift() | |||
|
|
|||
| if (nextMiddleware) { | |||
| return nextMiddleware(instance, runNext) | |||
| // return nextMiddleware(instance, runNext) | |||
README.md.hb
Outdated
| Middy supports middlewares that return promises instead that directly calling the callback: | ||
|
|
||
| ```javascript | ||
| const asyncValiator = () => { |
There was a problem hiding this comment.
asyncValiator to asyncValidator
README.md.hb
Outdated
| Thanks to this behaviour you can define middlewares using `async` functions: | ||
|
|
||
| ```javascript | ||
| const asyncValiator = () => { |
README.md.hb
Outdated
| } | ||
| } | ||
|
|
||
| handler.use(asyncValidator) |
There was a problem hiding this comment.
handler.use(asyncValidator)
|
Thanks, @dkatavic for the thorough review. I made the suggested changes. |
lmammino
force-pushed
the
feature/support-async-await
branch
from
a189c05
to
cb94a34
Compare
Closed
|
Very cool! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #49 and #50
This will add support for returning promises (instead of invoking the
nextcallback) and making possible to useasyncmiddlewares.More documentation and examples are coming soon.
TODO:
Now ready for review