Added support for async await in handler #59
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #59 +/- ##
=====================================
Coverage 100% 100%
=====================================
Files 10 10
Lines 157 165 +8
Branches 36 37 +1
=====================================
+ Hits 157 165 +8
Continue to review full report at Codecov.
|
|
@joseSantacruz can you please verify if the typescript changes here make sense? |
added 2 commits
December 15, 2017 16:18
lmammino
changed the title
peterjcaulfield
suggested changes
Dec 15, 2017
README.md
Outdated
| }) | ||
| ``` | ||
|
|
||
| We believe that the async/await version is easier to read and reason about. |
There was a problem hiding this comment.
This sentence is redundant based on sentence above I think.
src/__tests__/middy.js
Outdated
| }) | ||
| }) | ||
|
|
||
| test('An handler that returns a non-promise should trigger an error', (endTest) => { |
There was a problem hiding this comment.
typo. s/An handler/A handler
peterjcaulfield
approved these changes
Dec 15, 2017
dkatavic
approved these changes
Dec 15, 2017
src/__tests__/middy.js
Outdated
| }) | ||
| }) | ||
|
|
||
| test('An handler that returns a non-promise should trigger an error', (endTest) => { |
There was a problem hiding this comment.
What about handling then-able objects?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #52
TODO:
READY FOR REVIEW 馃