Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature/interrupt middlewares #77

Merged
merged 5 commits into from Jan 12, 2018
Merged

Feature/interrupt middlewares #77

merged 5 commits into from Jan 12, 2018

Conversation

lmammino
Copy link
Member

Closes #72

@lmammino lmammino self-assigned this Jan 11, 2018
@codecov
Copy link

codecov bot commented Jan 11, 2018 •
edited

Codecov Report

Merging #77 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@          Coverage Diff          @@
##           master    #77   +/-   ##
=====================================
  Coverage     100%   100%           
=====================================
  Files          10     10           
  Lines         165    166    +1     
  Branches       37     37           
=====================================
+ Hits          165    166    +1
Impacted Files Coverage Δ
src/middy.js 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cfc6438...bfa84e3. Read the comment docs.

dkatavic
dkatavic approved these changes Jan 11, 2018
View reviewed changes
Copy link
Contributor

@dkatavic dkatavic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great stuff @lmammino , as always

@lmammino
Copy link
Member Author

Thanks @dkatavic ;) i am going to wait for at least another approval before merging.

CC: @DavidWells let me know what do you think about this

@lmammino lmammino mentioned this pull request Jan 11, 2018
Closed
@lmammino
Copy link
Member Author

@NPCRUS, please have a look here and let us know if you think this is a decent implementation in terms of Developer Experience.

@lmammino
Copy link
Member Author

Given nobody else responded, I am getting this one merged

@lmammino lmammino merged commit aebeb30 into master Jan 12, 2018
@lmammino lmammino deleted the feature/interrupt-middlewares branch January 12, 2018 01:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dkatavic dkatavic dkatavic approved these changes

@DavidWells DavidWells Awaiting requested review from DavidWells

@peterjcaulfield peterjcaulfield Awaiting requested review from peterjcaulfield

@padraigobrien padraigobrien Awaiting requested review from padraigobrien

@techfort techfort Awaiting requested review from techfort

@acambas acambas Awaiting requested review from acambas

Assignees

@lmammino lmammino

Labels
core documentation enhancement
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@lmammino @dkatavic