Fix urlEncodeBodyParser when Content-Type header contains charset #82
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Decode body when Content-Type contains more than 'application/x-www-form-urlencoded'. Example: 'application/x-www-form-urlencoded; charset=UTF-8'
Codecov Report
@@ Coverage Diff @@
## master #82 +/- ##
=====================================
Coverage 100% 100%
=====================================
Files 11 11
Lines 183 183
Branches 38 38
=====================================
Hits 183 183
Continue to review full report at Codecov.
|
|
Very good catch. I will get this merged after #80 |
lmammino
approved these changes
Jan 13, 2018
added 3 commits
January 12, 2018 23:20
This was referenced Jan 13, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Decode body when Content-Type contains more than 'application/x-www-form-urlencoded'.
Example: 'application/x-www-form-urlencoded; charset=UTF-8'
In current state urlEncodeBodyParser & validator middleware are useless if the origin is not exactly sending 'application/x-www-form-urlencoded'.
In my case I don't control the origin request unfortunately!