Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

remove GDA 4 condition for include in midgard_connection.c #211

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

remove GDA 4 condition for include in midgard_connection.c #211

wants to merge 1 commit into from

Commits on Dec 14, 2015

  1. remove GDA 4 condition for include in midgard_connection.c 

    This condition appears to be a relic from when GDA 3 was supported. The block containing the gda_sql_parser_new function in this file used to have this GDA 4 condition as well, but it doesn't anymore [1], meaning that it implicitly declares the function and converts it to a pointer when GDA 5 is used, as can be seen here [2].

[1] 581404e#diff-da9c63301e7dc484369c3a9d6100fd0a
[2] https://launchpadlibrarian.net/229882653/buildlog_ubuntu-xenial-s390x.midgard2-core_10.05.7.1-2_BUILDING.txt.gz
    @loganrosen
    loganrosen committed Dec 14, 2015
    Configuration menu
    Copy the full SHA
    015db0f View commit details
    Browse the repository at this point in the history