Skip to content

Commit

Permalink
bail out if the original blob is 0 bytes long
Browse files Browse the repository at this point in the history
  • Loading branch information
feri committed Dec 22, 2011
1 parent ebf7aff commit c593619
Showing 1 changed file with 10 additions and 1 deletion.
11 changes: 10 additions & 1 deletion helpers.php
Expand Up @@ -104,6 +104,15 @@ public static function variant_is_fresh(midgard_attachment $variant, $parent=nul
*/
public static function generate_variant(midgard_attachment $original, $variant, $force_regenerate = false)
{
$original_blob = midgardmvc_helper_attachmentserver_helpers::get_blob($original);

if (! filesize($original_blob->get_path()))
{
// we can't do much with 0 byte long files
midgardmvc_core::get_instance()->log('The blob: ' . $original_blob->get_path() . ' is 0 byte long, can not process it.', 'error');
return null;
}

$old_variant = midgardmvc_helper_attachmentserver_helpers::get_variant($original, $variant);
if ($old_variant !== false)
{
Expand Down Expand Up @@ -135,7 +144,6 @@ public static function generate_variant(midgard_attachment $original, $variant,
throw new midgardmvc_exception("Variant {$variant} is not defined");
}

$original_blob = midgardmvc_helper_attachmentserver_helpers::get_blob($original);
if (empty($original->mimetype))
{
$original->mimetype = midgardmvc_helper_attachmentserver_helpers::resolve_mime_type($original_blob->get_path());
Expand All @@ -152,6 +160,7 @@ public static function generate_variant(midgard_attachment $original, $variant,
$converter->createTransformation($variant, $filters, array($original->mimetype));

$transformed_image = tempnam(sys_get_temp_dir(), "{$original->guid}_{$variant}");

$converter->transform
(
$variant,
Expand Down

0 comments on commit c593619

Please sign in to comment.