Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Soundtrack Language Support + Newzbin provider fixes #226

Open
wants to merge 6 commits into
base: master
Choose a base branch
from
Open

Soundtrack Language Support + Newzbin provider fixes #226

wants to merge 6 commits into from

Conversation

Toilal
Copy link

@Toilal Toilal commented Nov 12, 2011

Added: Soundtrack Language support in application. New Soundtrack Language parameter in TVShow.

Added: Soundtrack Language support in Newzbin provider. Other providers
are not implemented yet.

Added: Custom Search Names parameter to TVShow objects. Very useful
to force a custom scene release name (TVDB translates show names, scene
does not).

Added: Exception logging method (exceptions module).

Fixed: Newzbin provider in Download/Blackhole mode, SSL Read error
(urllib > urllib2)

Git: Some ignore added (for PyDev/Eclipse)

Sorry for the big commit, that was 1st time i use GIT, next time i will make more commits (1 commit / function)

Language parameter in TVShow.

Added: Soundtrack Language support in Newzbin provider. Other providers
are not implemented yet.

Added: Custom Search Names parameter to TVShow objects. Very useful
to force a custom scene release name (TVDB translates show names, scene
does not).

Added: Exception logging method (exceptions module).

Fixed: Newzbin provider in Download/Blackhole mode, SSL Read error
(urllib > urllib2)

Git: Some ignore added (for PyDev/Eclipse)
skip. changed "postdate" to "pubDate" (API change?)
@tobiaszuercher
Copy link

nice pull request, when is it comming?

@thezoggy
Copy link
Contributor

seems like there is a bunch of things grouped into one pull request. i'd recommend breaking each feature out to its own if you really want this to be pulled. also not sure what soundtrack language support is..

@tobiaszuercher
Copy link

soundtrack language support is the ability to choose the language for the movie. its possible to download tv shows in other language than english (if the provider supports it).

at least the newzbin patch should be pulled because newzbin still doesn't work (SSL read error)

@thezoggy
Copy link
Contributor

also, you shouldn't work in your 'master' branch as it will just get cluttered with midget's commits if you pull/update it. also, i'd recommend breaking each feature out to its own if you really want this to be pulled. as each thing needs to be tested before it would make it into master.

@an0Nym0us63
Copy link

Hello toilal, im very sad to see That your fork of sickbeard disapeared. I was using it With some customization i did for à long. But unfortunately i made some cleanup and lost everything. So i was able to modify your source to make it work like i wanted With newzbin nzbmatrix and nzb.su. But those modifications was made on your développement such as foreign langage and custom scene naming and That was magically working. But im only à new coing Guy, and i am able to adapt or modify existing code but im totally unable to code what toi did. So are you able,please, to reup your source With soundtrack and custom scène naming. Im french and it was very use full for me. Thank you please

@Toilal
Copy link
Author

Toilal commented Aug 6, 2012

Sorry, i don't have the sources anymore :(

But you can still see changes in this pull request ... and merge them.

@an0Nym0us63
Copy link

Thanks i did it and its working pretty well

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
4 participants