Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[WORK IN PROGRESS] Separate EOX message from SYSEX message #370

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

[WORK IN PROGRESS] Separate EOX message from SYSEX message #370

wants to merge 1 commit into from

Conversation

rdoursenaud
Copy link
Member

@rdoursenaud rdoursenaud commented Apr 13, 2022 •
edited

NOT PRODUCTION READY, CONTAINS A BUNCH OF UNRESOLVED FIXMEs AND TODOs.
ONLY PUBLISHED FOR REVIEW PURPOSES!

Fixes #363

Also implements

Known bugs

  • Sending EOX alone seems to not be supported by the WinMM API and triggers an RtMidi error
  • The argument used for RtMidi delta time is not fit for this purpose

TODO

  • Running status support:
  • Get delta time from rtmidi backend
  • EOX message support:
    • Receiving as separate message
    • Always emit after SysEx if missing
  • Optional SysEx filtering
    • Only parse messages compliant with a user provided lists of manufacturer ID codes.
      Pay special attention to the Universal System Exclusive IDs (0x7e & 0x7f) that should always be received
  • Optionally return messages and/or raise exceptions on Undefined Status, Unexpected data or any Invalid message

@rdoursenaud rdoursenaud added the feature:protocol MIDI Protocol implementation label Jan 19, 2023
@rdoursenaud rdoursenaud mentioned this pull request Jan 19, 2023
Open
@rdoursenaud
[WORK IN PROGRESS] Separate EOX message from SYSEX message
71f5a36 
Fixes mido#363

Also implements:
 - receiving Running Status (Does *not* implement sending with Running Status yet)
   Fixes mido#340
 - getting delta time from rtmidi backend (In a bad way for the moment)
   Fixes mido#241

 NOT PRODUCTION READY, CONTAINS A BUNCH OF UNRESOLVED FIXMEs AND TODOs.
 ONLY PUBLISHED FOR REVIEW PURPOSES!
@rdoursenaud
Copy link
Member Author

This tries to do too much in one go. I'll split every feature into their own commit for inclusion in mido version 2.
Work already started. See: https://github.com/mido/mido/tree/2.x

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
feature:protocol MIDI Protocol implementation
Projects
None yet
Milestone
No milestone
1 participant
@rdoursenaud