Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GatewayMappingService: fix Gateway selection... #7

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

blook
Copy link
Contributor

@blook blook commented Dec 20, 2018

... for negative hashes

@yamt
Copy link
Contributor

yamt commented Dec 25, 2018

thank you for the patch.
the patch itself looks good to me. (well, it would be great if you can include a unit test)
but we usually use gerrit to submit patches, not github PRs here.
see https://github.com/midonet/midonet/blob/master/DEVELOPMENT.md#how-to-contribute

@blook
Copy link
Contributor Author

blook commented Dec 27, 2018

thanks for your feedback. I submitted the patch on gerrit. Unfortunately I am not able to add a "tested" unit-test, because the current master is raising an exception while trying to run
gradlew midolman:test
Execution failed for task ':midolman:linkNativeFlowControllerTestGoogleTestExe'.

I would love to contribute to the project the 'right' way. Would it be ok for you to contact you via email for further details?

Regards

Sebastian

@yamt
Copy link
Contributor

yamt commented Dec 29, 2018

maybe you are seeing libgtest/c++ abi incompatibility.
cf. https://review.gerrithub.io/c/midonet/midonet/+/400020
if so, rebuilding libgtest for your env can be a workaround.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants