Show tab popover relative to urlbar with no opacity changes #164
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Popovers really don't work well unless they're given an explicit position. So for a tab that may be the tab itself or better yet the urlbar of the containing browser. With some themes the entire tabs goes blank due to opacity changes, and even if it doesn't the translucency may leave the user unclear as to what's happening. So let's not do this. Fixes: midori-browser#163 Also use the popover to re-implement permission requests. Fixes: midori-browser#158
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Popovers really don't work well unless they're given an explicit
position. So for a tab that may be the tab itself or better yet
the urlbar of the containing browser.
With some themes the entire tabs goes blank due to opacity
changes, and even if it doesn't the translucency may leave
the user unclear as to what's happening. So let's not do this.
Fixes: #163
Also use the popover to re-implement permission requests.
Fixes: #158