New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show tab popover relative to urlbar with no opacity changes #164

Merged
merged 1 commit into from Nov 7, 2018

Conversation

Projects
None yet
1 participant
@kalikiana
Member

kalikiana commented Nov 5, 2018

screenshot from 2018-11-05 15-13-30
Popovers really don't work well unless they're given an explicit
position. So for a tab that may be the tab itself or better yet
the urlbar of the containing browser.

With some themes the entire tabs goes blank due to opacity
changes, and even if it doesn't the translucency may leave
the user unclear as to what's happening. So let's not do this.

Fixes: #163

Also use the popover to re-implement permission requests.

Fixes: #158

Show tab popover relative to urlbar with no opacity changes
Popovers really don't work well unless they're given an explicit
position. So for a tab that may be the tab itself or better yet
the urlbar of the containing browser.

With some themes the entire tabs goes blank due to opacity
changes, and even if it doesn't the translucency may leave
the user unclear as to what's happening. So let's not do this.

Fixes: #163

Also use the popover to re-implement permission requests.

Fixes: #158

@kalikiana kalikiana added this to the Lorem Ipsum milestone Nov 5, 2018

@kalikiana kalikiana self-assigned this Nov 5, 2018

@kalikiana kalikiana merged commit 9d58178 into midori-browser:master Nov 7, 2018

1 check passed

ci/circleci: build Your tests passed on CircleCI!
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment