Feature/icon update (#19)

* Changed logo/favicon from PNG to ICO format Now the icon will be displayed correctly when WEB page bookmark is put on desktop. Chrome OS has been confirmed working. * Fixed ico file type in html file * Stored original .svg
midstar · Dec 13, 2019 · 34407ac · 34407ac
1 parent 33e43bf
commit 34407ac
Show file tree

Hide file tree

Showing 5 changed files with 25 additions and 9 deletions.
diff --git a/templates/index.html b/templates/index.html
@@ -1,7 +1,7 @@
 <html>
 <head>
 <title>MediaWEB</title>
-<link rel="icon" type="image/png" href="/logo.png">
+<link rel="icon" type="image/x-icon" href="/logo.ico">
 <style>
 
 /******************************************************************************

diff --git a/templates/logo.ico b/templates/logo.ico
diff --git a/testmedia/logo.svg b/testmedia/logo.svg
diff --git a/webapi.go b/webapi.go
@@ -115,6 +115,8 @@ func (wa *WebAPI) serveHTTPStatic(w http.ResponseWriter, r *http.Request) {
 	} else {
 		if filepath.Ext(fileName) == ".html" {
 			w.Header().Set("Content-Type", "text/html")
+		} else if filepath.Ext(fileName) == ".ico" {
+			w.Header().Set("Content-Type", "image/x-icon")
 		} else {
 			w.Header().Set("Content-Type", "image/png")
 		}

diff --git a/webapi_test.go b/webapi_test.go
@@ -135,6 +135,10 @@ func TestStatic(t *testing.T) {
 	image := getBinary(t, "icon_folder.png", "image/png")
 	assertTrue(t, "", len(image) > 100)
 
+	// Get an icong
+	image = getBinary(t, "logo.ico", "image/x-icon")
+	assertTrue(t, "", len(image) > 100)
+
 	// Get a non-existing png
 	resp, err := http.Get(fmt.Sprintf("%s/invalid.html", baseURL))
 	assertExpectNoErr(t, "", err)