Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incorrect rendering of loading/intro image in some games #353

Closed
polpettedorso opened this issue Sep 24, 2018 · 17 comments
Closed

Incorrect rendering of loading/intro image in some games #353

polpettedorso opened this issue Sep 24, 2018 · 17 comments
Assignees
Labels

Comments

@polpettedorso
Copy link

Some of these games (e.g. Banshee, Hollywood Poker Pro, Bloody Money...) don't display correctely: please take a look at the attached picture.
This happen when installing via code, but it is ok via binary installation

1528468256097-20180608_162321-resized

@midwan midwan self-assigned this Sep 24, 2018
@midwan midwan added the bug label Sep 24, 2018
@midwan
Copy link
Collaborator

midwan commented Sep 25, 2018

@polpettedorso
Thanks for the report.

This is related to the latest updates I made in the dev version, where I merged in some code from WinUAE. It included blitter and drawing functions, and those I suspect caused this effect.

I'll look into it and fix it.

@midwan midwan changed the title Uncorrect rendering of loading/intro image in some games Incorrect rendering of loading/intro image in some games Sep 25, 2018
@nemo93
Copy link
Contributor

nemo93 commented Sep 27, 2018

Hi! I do confirm this behaviour also with Alien Breed2, Dungeon Master 2, Roadkill/CD32, Robocop2, Uridium2.

@midwan
Copy link
Collaborator

midwan commented Oct 6, 2018

@polpettedorso
Did you test this in the dev branch version or the master one?

I can't recreate it with the current dev which has the latest updates from WinUAE.

@polpettedorso
Copy link
Author

I just updated form source and the bug is still there... :-(

@CypherXG
Copy link

CypherXG commented Oct 7, 2018

Same bug i had on the iPad. But i never fixed it.
It has to do with the color rendering of the HAM Mode.

@polpettedorso
Copy link
Author

Same bug i had on the iPad. But i never fixed it.
It has to do with the color rendering of the HAM Mode.

Pelare note that in the stable version the bug does not occur

@midwan
Copy link
Collaborator

midwan commented Oct 7, 2018

@polpettedorso
OK, so does this happen only on HAM screens? How about HAM screens from Workbench, showing images?
In my version of Banshee, I didn't see the problem - unless there's another version that you tested with (e.g. CD32?)

Maybe I can recreate it with another title then, we'll see.

@polpettedorso
Copy link
Author

I Think it's only with ham screens.
I tried also with "links" (the golf game) whose menu are ham and it is all buggy

@CypherXG
Copy link

CypherXG commented Oct 8, 2018

I tried many Games like Blood Money or Demos.
It make no difference if they start from WHDLoad or direct from ADF File.
Also it make no difference if you are changing between OCS, ECS or AGA or changing the Chipset.
Best is to find out if you use a Paint Programm like Dpaint which can select a HAM Screenmode.
Here a Screenshot from Stryx:
screenshot
Here from Bloodmoney
screenshot
Or from Hollywood Poker Slideshow
Mmhhh in the Slideshow it look like that the Red color is missing or incorrect shown:
screenshot
screenshot

I hope i can help you with this informations...

@CypherXG
Copy link

CypherXG commented Oct 8, 2018

Pelare note that in the stable version the bug does not occur

In the stable Version the GFX Render Code was not changed.
After that the Statusbar was incorrect shown in 16bit RTG mode or in some Amiga Screenmodes.
The Scanlinebug is there and the wrong color mode.
I think something is wrong with the drawing or amiberrygfx code.
The picasso code seems to be ok, because RTG Render works and the errors are also shown if you don't usw WHD Load mit RTG in the backround.

@midwan
Copy link
Collaborator

midwan commented Oct 8, 2018

@CypherXG
Thanks, I think I know what caused this then.
I'll work on fixing it these days and update the dev branch accordingly, after testing it.

midwan added a commit that referenced this issue Oct 8, 2018
@midwan
Copy link
Collaborator

midwan commented Oct 8, 2018

This is now fixed, at least according to the tests I made with the samples mentioned above.
If you find another issue with HAM modes, please let me know.

@polpettedorso
Copy link
Author

Hi! I tested after updating form source, bug nothing changed. Am I doping something wrong?

@midwan
Copy link
Collaborator

midwan commented Oct 9, 2018

@polpettedorso
Are you sure you got the dev branch?

@CypherXG
Copy link

Dev branch is fixed. Working perfectly.
You have to replace only your drawing.cpp. That's all.

Nice work. Midwan.

@polpettedorso
Copy link
Author

Sorry to bother you again: I'm a newbie and not a programmer, but I'd like to contribute at least testing.
Via putty I gave the following instructions:

cd ~
git clone -b dev https://github.com/midwan/amiberry.git  
cd amiberry

then

make all
I come back to retropie, but there was still the old version of amiberry. Then I tried to update from source, but I think it installed the master version.

I'm sure I'm doing something wrong, but I couldn't figure out what.
Could you please help me?

thanks

@polpettedorso
Copy link
Author

Nevermind my request, i found this: https://github.com/midwan/amiberry/wiki/Compiling-Development-Branch and I did it.
Amiberry works great. I will keep on testing the new developments.
Thanks for the great work

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

4 participants