fix: fix cookie in fc apigw

midwayjs · May 2, 2020 · e15decb · e15decb
1 parent 4438758
commit e15decb
Show file tree

Hide file tree

Showing 3 changed files with 21 additions and 2 deletions.
diff --git a/packages/serverless-fc-starter/src/runtime.ts b/packages/serverless-fc-starter/src/runtime.ts
@@ -1,5 +1,8 @@
 import * as getRawBody from 'raw-body';
-import { FAAS_ARGS_KEY, ServerlessLightRuntime, } from '@midwayjs/runtime-engine';
+import {
+  FAAS_ARGS_KEY,
+  ServerlessLightRuntime,
+} from '@midwayjs/runtime-engine';
 import { Context } from '@midwayjs/serverless-http-parser';
 import * as util from 'util';
 
@@ -105,7 +108,17 @@ export class FCRuntime extends ServerlessLightRuntime {
       for (const key in ctx.res.headers) {
         // The length after base64 is wrong.
         if (!['content-length'].includes(key)) {
-          newHeader[key] = ctx.res.headers[key];
+          if ('set-cookie' === key && !isHTTPMode) {
+            // unsupport multiple cookie when use apiGateway
+            newHeader[key] = ctx.res.headers[key][0];
+            if (ctx.res.headers[key].length > 1) {
+              ctx.logger.warn(
+                `[fc-starter]: unsupport multiple cookie when use apiGateway`
+              );
+            }
+          } else {
+            newHeader[key] = ctx.res.headers[key];
+          }
         }
       }
 

diff --git a/packages/serverless-fc-starter/test/fixtures/apigw/index.ts b/packages/serverless-fc-starter/test/fixtures/apigw/index.ts
@@ -14,6 +14,10 @@ exports.handler = asyncWrapper(async (...args) => {
     deepStrictEqual(event.path, '/test');
     deepStrictEqual(event.httpMethod, 'POST');
     ctx.status = 200;
+    ctx.set('set-cookie', [
+      'bbbb=123; path=/; httponly',
+      'ccc=321; path=/; httponly',
+    ]);
     ctx.body = {
       headers: ctx.headers,
       method: ctx.method,

diff --git a/packages/serverless-fc-starter/test/index.test.ts b/packages/serverless-fc-starter/test/index.test.ts
@@ -450,6 +450,8 @@ describe('/test/index.test.ts', () => {
       assert(result.isBase64Encoded === false);
       assert(result.statusCode === 200);
       assert(result.headers);
+      assert(result.headers['set-cookie'] === 'bbbb=123; path=/; httponly');
+      result.headers;
       assert.equal(typeof result.body, 'string');
       const body = JSON.parse(result.body);
       assert.equal(body.method, 'POST');