fix: change private to protected (#49)

* fix: change private to protected * chore: update ioc.json
midwayjs · Feb 17, 2020 · f5373c7 · f5373c7
1 parent 4c48680
commit f5373c7
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 5 deletions.
diff --git a/packages/faas/src/starter.ts b/packages/faas/src/starter.ts
@@ -175,18 +175,21 @@ export class FaaSStarter implements IFaaSStarter {
   ) {
     return this.lock.sureOnce(async () => {
       let containerOptions = {};
-      try {
+      if (
+        existsSync(join(this.appDir, 'ioc.js')) ||
+        existsSync(join(this.appDir, 'ioc.json'))
+      ) {
         const containerOptPath = require.resolve(join(this.appDir, 'ioc'));
+        this.logger.info(
+          'midway-faas: ioc config is deprecated，use @Configuration instead.'
+        );
         containerOptions = require(containerOptPath);
         if (typeof containerOptions === 'function') {
           containerOptions = containerOptions({
             baseDir: this.baseDir,
             appDir: this.appDir,
           } as MidwayFaaSInfo);
         }
-      } catch (err) {
-        // ignore
-        this.logger.info('midway-faas: ioc config read fail and skip');
       }
 
       this.loader.loadDirectory(Object.assign(opts, containerOptions));

diff --git a/packages/serverless-invoke/src/core.ts b/packages/serverless-invoke/src/core.ts
@@ -45,7 +45,7 @@ export abstract class InvokeCore implements IInvoke {
     this.spec = loadSpec(this.baseDir);
   }
 
-  private async getStarter() {
+  protected async getStarter() {
     if (this.starter) {
       return this.starter;
     }