This repository has been archived by the owner on Jul 2, 2020. It is now read-only.
fix: invoke source map #52
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
echosoar
commented
Feb 19, 2020
•
echosoar
commented
- 修复invoke时sourceMap的root路径问题
- faas-cli 无命令时显示帮助
- faas 有个边界问题
- 在开发调试时，不生成 tsconfig
czy88840616
reviewed
Feb 19, 2020
Codecov Report
@@ Coverage Diff @@
## master #52 +/- ##
==========================================
- Coverage 70.87% 69.32% -1.56%
==========================================
Files 69 69
Lines 1940 1946 +6
Branches 183 183
==========================================
- Hits 1375 1349 -26
- Misses 531 563 +32
Partials 34 34
Continue to review full report at Codecov.
|
* fix: incremental params pass * chores: remove useless code * fix: incremental no effect * refactor: update clean flag * chore: clean test code * chore: clean test code * chore: update yml md Co-authored-by: Harry Chen <czy88840616@gmail.com>
Lxxyx
approved these changes
Feb 20, 2020
czy88840616
suggested changes
Feb 20, 2020
| } else { | ||
| await tsCompile(this.servicePath, { | ||
| clean: true, | ||
| tsConfigName: 'tsconfig.json', | ||
| source: this.options.sourceDir || 'src', | ||
| source: resolve(this.servicePath, 'src'), |
| await tsIntegrationProjectCompile(this.servicePath, { | ||
| sourceDir: this.options.sourceDir || 'src', | ||
| const tsConfig = await tsIntegrationProjectCompile(this.servicePath, { | ||
| sourceDir: resolve(this.servicePath, 'src'), |
| tsConfig.compilerOptions.incremental = options.incremental; | ||
| } | ||
| if (tsConfig.compilerOptions.incremental) { | ||
| tsConfig.compilerOptions.tsBuildInfoFile = resolve(baseDir, '.tsbuildinfo'); |
There was a problem hiding this comment.
这里我觉得有点问题。。。. tsbuildinfo 文件应该不能在根目录，得在build目录，不然不会被清理，一直被增量。
| join(baseDir, 'tsconfig_integration_faas.json'), | ||
| join(this.buildDir, 'tsconfig.json'), | ||
| opts | ||
| ); | ||
| } else { | ||
| // TODO 重构 midway-bin 不生成 tsconfig |
| } else { | ||
| // TODO 重构 midway-bin 不生成 tsconfig | ||
| await tsCompile(baseDir, { | ||
| source: 'src', | ||
| source: resolve(baseDir, 'src'), |
There was a problem hiding this comment.
总觉得这里应该读传相对路径，要绝对路径也只在最底层处理
legendecas
approved these changes
Feb 20, 2020
Lellansin
approved these changes
Feb 20, 2020
czy88840616
approved these changes
Feb 21, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.