fix: health check missing this resolver (#3700)

midwayjs · May 6, 2024 · eedd961 · eedd961
1 parent 1bb51da
commit eedd961
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 2 deletions.
diff --git a/packages/core/src/service/healthService.ts b/packages/core/src/service/healthService.ts
@@ -46,7 +46,9 @@ export class MidwayHealthService {
         lifecycleInstance.instance['onHealthCheck']
       ) {
         this.healthCheckMethods.push({
-          item: lifecycleInstance.instance['onHealthCheck'],
+          item: lifecycleInstance.instance['onHealthCheck'].bind(
+            lifecycleInstance.instance
+          ),
           meta: {
             namespace: lifecycleInstance.namespace,
           },

diff --git a/packages/core/test/fixtures/app-with-health-check/src/configuration.ts b/packages/core/test/fixtures/app-with-health-check/src/configuration.ts
@@ -1,11 +1,15 @@
-import { Configuration, ILifeCycle, sleep } from '../../../../src';
+import { ApplicationContext, Configuration, ILifeCycle, IMidwayContainer, sleep } from '../../../../src';
+import { ok } from 'assert';
 
 @Configuration({
 })
 export class AutoConfiguration implements ILifeCycle {
+  @ApplicationContext()
+  applicationContext: IMidwayContainer;
   async onReady(){}
 
   async onHealthCheck() {
+    ok(this.applicationContext);
     await sleep(100);
     return {
       status: true,