Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(serverless-app): fix findNpmModule in pnp #1605

Merged
merged 1 commit into from
Jan 21, 2022
Merged

fix(serverless-app): fix findNpmModule in pnp #1605

merged 1 commit into from
Jan 21, 2022

Conversation

zhyupe
Copy link
Contributor

@zhyupe zhyupe commented Jan 20, 2022

Checklist
  • npm test passes
  • tests and/or benchmarks are included
  • commit message follows commit guidelines
Affected core subsystem(s)

serverless-app

Description of change

findNpmModule always returns false when using yarn pnp. This PR detects pnp environment and uses require.resolve in pnp.

@gitpod-io
Copy link

gitpod-io bot commented Jan 20, 2022

@czy88840616 czy88840616 merged commit d275f64 into midwayjs:2.x Jan 21, 2022
czy88840616 pushed a commit that referenced this pull request Jan 21, 2022
@zhyupe @czy88840616
fix(serverless-app): fix findNpmModule in pnp (#1605)
37f46e0
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@czy88840616 czy88840616 czy88840616 approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@zhyupe @czy88840616