New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: custom decorator with decorators manager #102
Conversation
Codecov Report
@@ Coverage Diff @@
## master #102 +/- ##
==========================================
- Coverage 81.65% 80.83% -0.83%
==========================================
Files 75 76 +1
Lines 2197 2228 +31
Branches 323 327 +4
==========================================
+ Hits 1794 1801 +7
- Misses 281 305 +24
Partials 122 122
Continue to review full report at Codecov.
|
目前问题:如果在 app.ts 里面的 module.exports = (app) => app.xxx.register( .... ) 里面注册,那么很可能出现的问题是用户无法劫持原有的方法:因为 controller 上的一些对象可能已经被内部框架持有,此时注册装饰器要劫持其方法已经晚了。 |
@kurten 也看看 |
|
@Lellansin 把你的实现在 issue 里描述下吧,光看 PR 没有头绪。 |
* feat: expose handler not found error to invoker * fix: test case Co-authored-by: Harry Chen <czy88840616@gmail.com>
Checklist
npm test
passesAffected core subsystem(s)
Description of change