fix: import router to fix core #131
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kurten
approved these changes
Jan 30, 2019
Lellansin
approved these changes
Jan 30, 2019
Codecov Report
@@ Coverage Diff @@
## master #131 +/- ##
=========================================
- Coverage 76.66% 76.57% -0.1%
=========================================
Files 28 27 -1
Lines 767 764 -3
Branches 114 114
=========================================
- Hits 588 585 -3
Misses 139 139
Partials 40 40
Continue to review full report at Codecov.
|
czy88840616
pushed a commit
that referenced
this pull request
Jan 30, 2019
Merge pull request #131 from midwayjs/fix_core fix: import router to fix core
czy88840616
pushed a commit
that referenced
this pull request
Jul 2, 2020
* fix: process * fix: tencent-support * fix: support timer * fix: test
This was referenced Nov 25, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
egg-core 移除了 Router 导致依赖出错，后期通过自定义装饰器减弱对内部库的依赖。