Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: close logger before egg app close #1928

Merged
merged 1 commit into from Apr 21, 2022

Conversation

czy88840616
Copy link
Member

@czy88840616 czy88840616 commented Apr 21, 2022

fix: #1862

@gitpod-io
Copy link

gitpod-io bot commented Apr 21, 2022

@codecov-commenter
Copy link

codecov-commenter commented Apr 21, 2022

Codecov Report

Merging #1928 (fe3015c) into main (e2fd742) will increase coverage by 0.01%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main    #1928      +/-   ##
==========================================
+ Coverage   82.11%   82.12%   +0.01%     
==========================================
  Files         403      403              
  Lines       13438    13444       +6     
  Branches     3124     3126       +2     
==========================================
+ Hits        11034    11041       +7     
+ Misses       2202     2201       -1     
  Partials      202      202              
Impacted Files Coverage Δ
packages/web/src/logger.ts 70.49% <100.00%> (+1.52%) ⬆️
packages/upload/src/parse.ts 95.93% <0.00%> (+0.81%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e2fd742...fe3015c. Read the comment docs.

@czy88840616 czy88840616 merged commit d30d21f into main Apr 21, 2022
@czy88840616 czy88840616 deleted the fix_logger_close_before_egg_close branch April 21, 2022 07:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

"[winston] Attempt to write logs with no transports" printed even when test is passed
2 participants