Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: serviceFactory support default client name #2482

Merged
merged 2 commits into from Nov 17, 2022

Conversation

czy88840616
Copy link
Member

Checklist
  • npm test passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines
Affected core subsystem(s)
Description of change

@gitpod-io
Copy link

gitpod-io bot commented Nov 6, 2022

@czy88840616 czy88840616 changed the title feat: support default client name feat: serviceFactory support default client name Nov 6, 2022
@czy88840616 czy88840616 added the pr: new feature This PR adds a new API or behavior. label Nov 6, 2022
@codecov-commenter
Copy link

codecov-commenter commented Nov 6, 2022

Codecov Report

Base: 83.20% // Head: 83.20% // Increases project coverage by +0.00% 🎉

Coverage data is based on head (f9b1178) compared to base (7ab133c).
Patch coverage: 85.71% of modified lines in pull request are covered.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2482   +/-   ##
=======================================
  Coverage   83.20%   83.20%           
=======================================
  Files         401      401           
  Lines       14070    14077    +7     
  Branches     3320     3326    +6     
=======================================
+ Hits        11707    11713    +6     
- Misses       2153     2154    +1     
  Partials      210      210           
Impacted Files Coverage Δ
packages/core/src/interface.ts 100.00% <ø> (ø)
packages/cos/src/manager.ts 47.82% <0.00%> (-2.18%) ⬇️
packages/axios/src/serviceManager.ts 85.00% <100.00%> (+0.38%) ⬆️
packages/core/src/common/serviceFactory.ts 86.66% <100.00%> (+0.45%) ⬆️
packages/oss/src/manager.ts 85.36% <100.00%> (+0.75%) ⬆️
packages/redis/src/manager.ts 69.64% <100.00%> (+0.55%) ⬆️
packages/tablestore/src/manager.ts 100.00% <100.00%> (ø)
packages/captcha/src/service.ts 77.77% <0.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@czy88840616 czy88840616 merged commit 170092f into main Nov 17, 2022
@czy88840616 czy88840616 deleted the support_default_client branch November 17, 2022 15:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr: new feature This PR adds a new API or behavior.
Development

Successfully merging this pull request may close these issues.

None yet

2 participants