Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: swagger query object #2547

Merged
merged 2 commits into from Dec 19, 2022
Merged

Conversation

lhcn
Copy link
Contributor

@lhcn lhcn commented Dec 2, 2022

遇到和下面issue同样的问题,跟了一下源码,改好顺便提个pr。
#2521

修改后效果:如果@query装饰的是一个对象,则把这个对象的所有子属性作为多个query参数。

@czy88840616 czy88840616 added the pr: bug fix This PR fixes a bug in a past release. label Dec 2, 2022
@codecov-commenter
Copy link

codecov-commenter commented Dec 2, 2022

Codecov Report

Base: 83.22% // Head: 83.08% // Decreases project coverage by -0.14% ⚠️

Coverage data is based on head (faf420f) compared to base (7dd32cf).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2547      +/-   ##
==========================================
- Coverage   83.22%   83.08%   -0.15%     
==========================================
  Files         405      405              
  Lines       14126    14135       +9     
  Branches     3335     3337       +2     
==========================================
- Hits        11757    11744      -13     
- Misses       2160     2177      +17     
- Partials      209      214       +5     
Impacted Files Coverage Δ
packages/swagger/src/swaggerExplorer.ts 81.19% <100.00%> (+0.83%) ⬆️
packages/oss/src/manager.ts 31.70% <0.00%> (-53.66%) ⬇️
packages/oss/src/configuration.ts 60.00% <0.00%> (-40.00%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@czy88840616 czy88840616 changed the title support query object fix: swagger query object Dec 8, 2022
@czy88840616 czy88840616 merged commit c536193 into midwayjs:main Dec 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr: bug fix This PR fixes a bug in a past release.
Development

Successfully merging this pull request may close these issues.

None yet

4 participants