Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: @config(opt) decorator opt accept dot notation #258

Merged
merged 2 commits into from Jul 2, 2019

Conversation

yviscool
Copy link
Contributor

@yviscool yviscool commented Jul 1, 2019

config 装饰器支持点符号获取多级属性

@yviscool yviscool changed the title feat: @config(opt) decorator opt accept dot natation feat: @config(opt) decorator opt accept dot notation Jul 1, 2019
@waitingsong
Copy link
Member

safelyGet() 参数没类型?

@yviscool
Copy link
Contributor Author

yviscool commented Jul 1, 2019

@waitingsong utils.ts 能找到一个类型算我输 😏

@waitingsong
Copy link
Member

你来写个any ...

waitingsong added a commit to waitingsong/midway that referenced this pull request Jul 1, 2019
@waitingsong
Copy link
Member

现在有了 😏

@czy88840616 czy88840616 self-requested a review July 1, 2019 15:43
Copy link
Member

@czy88840616 czy88840616 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@codecov-io
Copy link

codecov-io commented Jul 1, 2019

Codecov Report

Merging #258 into master will decrease coverage by 0.38%.
The diff coverage is 71.42%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master    #258      +/-   ##
=========================================
- Coverage   88.49%   88.1%   -0.39%     
=========================================
  Files          35      35              
  Lines         669     681      +12     
  Branches       44      47       +3     
=========================================
+ Hits          592     600       +8     
- Misses         68      71       +3     
- Partials        9      10       +1
Impacted Files Coverage Δ
packages/midway-web/src/loader/webLoader.ts 90.9% <100%> (ø) ⬆️
packages/midway-web/src/utils.ts 88.57% <66.66%> (-11.43%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b7d478a...c360cc0. Read the comment docs.

@czy88840616 czy88840616 merged commit 8f12422 into midwayjs:master Jul 2, 2019
czy88840616 pushed a commit that referenced this pull request Jul 2, 2019
Merge pull request #258 from yviscool/master

feat: @config(opt) decorator opt accept dot notation
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants