Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: ignore migrate options for typeorm running #2590

Merged
merged 1 commit into from Dec 20, 2022

Conversation

czy88840616
Copy link
Member

Checklist
  • npm test passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines
Affected core subsystem(s)
Description of change

@codecov-commenter
Copy link

codecov-commenter commented Dec 20, 2022

Codecov Report

Base: 81.93% // Head: 81.93% // Increases project coverage by +0.00% 🎉

Coverage data is based on head (56f9c9f) compared to base (b3daa46).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2590   +/-   ##
=======================================
  Coverage   81.93%   81.93%           
=======================================
  Files         414      414           
  Lines       14667    14669    +2     
  Branches     3460     3461    +1     
=======================================
+ Hits        12017    12019    +2     
  Misses       2404     2404           
  Partials      246      246           
Impacted Files Coverage Δ
packages/typeorm/src/dataSourceManager.ts 80.95% <100.00%> (+2.00%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@czy88840616 czy88840616 added the pr: bug fix This PR fixes a bug in a past release. label Dec 20, 2022
@czy88840616 czy88840616 merged commit 17591c3 into main Dec 20, 2022
@czy88840616 czy88840616 deleted the ignore_migrate_in_orm branch December 20, 2022 06:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr: bug fix This PR fixes a bug in a past release.
Development

Successfully merging this pull request may close these issues.

None yet

2 participants