Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: @valid with other decorator #2703

Merged
merged 1 commit into from
Feb 2, 2023
Merged

fix: @valid with other decorator #2703

merged 1 commit into from
Feb 2, 2023

Conversation

czy88840616
Copy link
Member

Checklist
  • npm test passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines
Affected core subsystem(s)
Description of change

@czy88840616 czy88840616 added the pr: bug fix This PR fixes a bug in a past release. label Feb 2, 2023
@codecov-commenter
Copy link

codecov-commenter commented Feb 2, 2023

Codecov Report

Base: 82.02% // Head: 82.03% // Increases project coverage by +0.00% 🎉

Coverage data is based on head (3285544) compared to base (a2d7ad7).
Patch coverage: 88.00% of modified lines in pull request are covered.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2703   +/-   ##
=======================================
  Coverage   82.02%   82.03%           
=======================================
  Files         419      419           
  Lines       15022    15019    -3     
  Branches     3564     3561    -3     
=======================================
- Hits        12322    12321    -1     
+ Misses       2450     2448    -2     
  Partials      250      250           
Impacted Files Coverage Δ
packages/core/src/service/decoratorService.ts 92.23% <ø> (ø)
packages/validate/src/decorator/rule.ts 90.47% <84.61%> (-2.39%) ⬇️
packages/cross-domain/src/jsonp.ts 94.11% <90.90%> (-0.89%) ⬇️
packages/validate/src/constants.ts 100.00% <100.00%> (ø)
packages/bootstrap/src/util.ts 83.87% <0.00%> (-6.46%) ⬇️
packages/otel/src/configuration.ts 100.00% <0.00%> (ø)
packages/otel/src/service.ts 100.00% <0.00%> (+33.33%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@czy88840616 czy88840616 merged commit 66e801d into main Feb 2, 2023
@czy88840616 czy88840616 deleted the fix_valid_with_pipe branch February 2, 2023 16:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr: bug fix This PR fixes a bug in a past release.
Development

Successfully merging this pull request may close these issues.

None yet

2 participants