Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: mock service inited will be before lifecycle #2764

Merged
merged 5 commits into from Mar 10, 2023

Conversation

czy88840616
Copy link
Member

Checklist
  • npm test passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines
Affected core subsystem(s)
Description of change

@czy88840616 czy88840616 added the pr: bug fix This PR fixes a bug in a past release. label Feb 24, 2023
@czy88840616 czy88840616 changed the title Fix mock service sequence fix: mock service inited will be before lifecycle Feb 24, 2023
@codecov-commenter
Copy link

codecov-commenter commented Mar 10, 2023

Codecov Report

Patch coverage: 35.71% and no project coverage change.

Comparison is base (15cede3) 82.02% compared to head (a4f925d) 82.02%.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2764   +/-   ##
=======================================
  Coverage   82.02%   82.02%           
=======================================
  Files         421      421           
  Lines       15126    15129    +3     
  Branches     3590     3590           
=======================================
+ Hits        12407    12410    +3     
  Misses       2469     2469           
  Partials      250      250           
Impacted Files Coverage Δ
packages/core/src/service/mockService.ts 77.31% <25.00%> (-2.47%) ⬇️
packages/core/src/setup.ts 95.14% <100.00%> (ø)

... and 2 files with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@czy88840616 czy88840616 merged commit 6cb3c30 into main Mar 10, 2023
7 checks passed
@czy88840616 czy88840616 deleted the fix_mock_service_sequence branch March 10, 2023 06:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr: bug fix This PR fixes a bug in a past release.
Development

Successfully merging this pull request may close these issues.

None yet

2 participants