Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(core): add boolean property JoinPoint['proceedIsAsyncFunction'] #2841

Merged
merged 3 commits into from Apr 2, 2023

Conversation

waitingsong
Copy link
Member

@waitingsong waitingsong commented Mar 29, 2023

indicate aop proceed whether AsyncFunction or not

判断 经过aop 包裹后的方法是否异步函数比较麻烦,添加一个属性来表明方法异步性

indicate aop proceed whether AsyncFunction or not
@codecov-commenter
Copy link

Codecov Report

Patch coverage has no change and project coverage change: -0.16 ⚠️

Comparison is base (1b93df4) 81.61% compared to head (bccf6fd) 81.45%.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2841      +/-   ##
==========================================
- Coverage   81.61%   81.45%   -0.16%     
==========================================
  Files         437      437              
  Lines       15764    15764              
  Branches     3719     3719              
==========================================
- Hits        12866    12841      -25     
- Misses       2630     2650      +20     
- Partials      268      273       +5     
Impacted Files Coverage Δ
packages/core/src/interface.ts 100.00% <ø> (ø)
packages/core/src/service/aspectService.ts 92.59% <ø> (ø)

... and 3 files with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@czy88840616 czy88840616 added the pr: polish This PR adds a very minor behavior improvement that users will enjoy. label Mar 29, 2023
@waitingsong
Copy link
Member Author

考虑了下, 会在日常开发中基本接触不到 joinPoint,能用到的情况也是只读,所以对于 JoinPoint['proceedIsAsyncFunction'] 类型值添加 undefined 似乎画蛇添足了。
还是删除了。

@czy88840616 czy88840616 merged commit e04e27b into midwayjs:main Apr 2, 2023
2 checks passed
@waitingsong waitingsong deleted the core-aop branch April 2, 2023 16:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr: polish This PR adds a very minor behavior improvement that users will enjoy.
Development

Successfully merging this pull request may close these issues.

None yet

3 participants