Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support app enable ssl custom certificate in dev mode #2899

Merged

Conversation

Steppenwolf1900
Copy link
Contributor

@Steppenwolf1900 Steppenwolf1900 commented Apr 22, 2023

midway-bin dev 下,应用在本地开发时也可以快速使用 --ssl --https.key=./ssl/key.pem --https.cert=./ssl/cert.pem 指定私钥及证书文件来启动 https 服务 #2900

@codecov-commenter
Copy link

codecov-commenter commented Apr 23, 2023

Codecov Report

Patch coverage has no change and project coverage change: -0.14 ⚠️

Comparison is base (21a26db) 81.67% compared to head (8e85309) 81.53%.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2899      +/-   ##
==========================================
- Coverage   81.67%   81.53%   -0.14%     
==========================================
  Files         437      437              
  Lines       15826    15826              
  Branches     3734     3734              
==========================================
- Hits        12926    12904      -22     
- Misses       2632     2649      +17     
- Partials      268      273       +5     

see 4 files with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@czy88840616 czy88840616 added the pr: polish This PR adds a very minor behavior improvement that users will enjoy. label Apr 23, 2023
@czy88840616 czy88840616 merged commit 13d8a1d into midwayjs:main Apr 23, 2023
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr: polish This PR adds a very minor behavior improvement that users will enjoy.
Development

Successfully merging this pull request may close these issues.

None yet

3 participants