Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(boilerplate): fix building issue cause of .tsbuildinfo #298

Merged
merged 2 commits into from
Jul 29, 2019

Conversation

waitingsong
Copy link
Member

@waitingsong waitingsong commented Jul 28, 2019

It will no output during tsc incremental build if outDir is empty and .tsbuildinfo exists.
Add scripts npm run clean to unlink files in outDir and file .tsbuildinfo .

Checklist
  • npm test passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines
Affected core subsystem(s)
Description of change

启用 tsc 的 incremental 编译参数后,若 删除了 ourDir 下的编译输出文件,则下次编译就不会有输出。需要删除掉 .tsbuildinfo 文件后才正常。
所以增加一条清除的脚本命令 npm run clean 用于删除编辑结果文件以及相关 .tsbuildinfo 文件。

It will no output during tsc incremental build if outDir is empty and .tsbuildinfo exists.
Add scripts `npm run clean` to unlink files in outDir and file .tsbuildinfo .
@codecov-io
Copy link

codecov-io commented Jul 28, 2019

Codecov Report

Merging #298 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #298   +/-   ##
=======================================
  Coverage   86.61%   86.61%           
=======================================
  Files          35       35           
  Lines         695      695           
  Branches       48       48           
=======================================
  Hits          602      602           
  Misses         83       83           
  Partials       10       10

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update af9e356...469926b. Read the comment docs.

@waitingsong
Copy link
Member Author

dev 依赖中增加一个 rimraf。不知道 midway 是否有内置的删除命令。

@czy88840616 czy88840616 merged commit c695ce0 into midwayjs:master Jul 29, 2019
czy88840616 pushed a commit that referenced this pull request Jul 29, 2019
chore(boilerplate): fix building issue cause of .tsbuildinfo (#298)

chore(boilerplate): fix building issue cause of .tsbuildinfo
@waitingsong waitingsong deleted the boilerplate branch July 29, 2019 09:08
@czy88840616
Copy link
Member

@waitingsong
Copy link
Member Author

waitingsong commented Jul 29, 2019

midway-bin-clean 匹配规则是否支持通配 比如 .vscode/.tsbuildinfo.* .
如果可行,我再修改下,尽量少依赖。

@waitingsong
Copy link
Member Author

另外,是否支持在script中调用?
scripts: {
"clean": "midway-bin clean"
}

然后在命令行执行 npm run clean

@czy88840616
Copy link
Member

czy88840616 commented Jul 29, 2019

命令行调用当然支持,通配的话,看了一下貌似不支持,不过build的时候拷贝是支持的,可以抄一下。。

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants