Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support new faas v3 entry #2996

Merged
merged 1 commit into from May 30, 2023
Merged

feat: support new faas v3 entry #2996

merged 1 commit into from May 30, 2023

Conversation

czy88840616
Copy link
Member

Checklist
  • npm test passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines
Affected core subsystem(s)
Description of change

@czy88840616 czy88840616 added the pr: polish This PR adds a very minor behavior improvement that users will enjoy. label May 30, 2023
@codecov-commenter
Copy link

Codecov Report

Patch coverage: 44.82% and project coverage change: +0.06 🎉

Comparison is base (539f4a2) 81.65% compared to head (46e6b5a) 81.71%.

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2996      +/-   ##
==========================================
+ Coverage   81.65%   81.71%   +0.06%     
==========================================
  Files         437      437              
  Lines       15863    15888      +25     
  Branches     3744     3755      +11     
==========================================
+ Hits        12953    12983      +30     
+ Misses       2639     2635       -4     
+ Partials      271      270       -1     
Impacted Files Coverage Δ
packages/faas/src/starter.ts 37.83% <26.31%> (-14.80%) ⬇️
packages/mock/src/creator.ts 70.90% <80.00%> (+7.10%) ⬆️

... and 2 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@czy88840616 czy88840616 merged commit bbbe331 into main May 30, 2023
7 checks passed
@czy88840616 czy88840616 deleted the support_new_faas_entry branch May 30, 2023 09:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr: polish This PR adds a very minor behavior improvement that users will enjoy.
Development

Successfully merging this pull request may close these issues.

None yet

2 participants