Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: bootstrap close entry #3000

Merged
merged 3 commits into from
May 31, 2023
Merged

fix: bootstrap close entry #3000

merged 3 commits into from
May 31, 2023

Conversation

czy88840616
Copy link
Member

@czy88840616 czy88840616 commented May 31, 2023

现在 mock 的 close 方法支持 bootstrap 和普通 app 两种,统一了 api

@czy88840616 czy88840616 added the pr: bug fix This PR fixes a bug in a past release. label May 31, 2023
@codecov-commenter
Copy link

Codecov Report

Patch coverage: 79.16% and project coverage change: -0.03 ⚠️

Comparison is base (4899f40) 81.69% compared to head (ab2b80d) 81.66%.

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3000      +/-   ##
==========================================
- Coverage   81.69%   81.66%   -0.03%     
==========================================
  Files         437      437              
  Lines       15888    15897       +9     
  Branches     3755     3759       +4     
==========================================
+ Hits        12979    12983       +4     
- Misses       2638     2643       +5     
  Partials      271      271              
Impacted Files Coverage Δ
packages/mock/src/creator.ts 70.42% <79.16%> (-0.49%) ⬇️

... and 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@czy88840616 czy88840616 merged commit ce624ed into main May 31, 2023
7 checks passed
@czy88840616 czy88840616 deleted the fix_close_entry branch May 31, 2023 09:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr: bug fix This PR fixes a bug in a past release.
Development

Successfully merging this pull request may close these issues.

None yet

2 participants