Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support all http methods #3110

Merged
merged 2 commits into from Aug 13, 2023
Merged

Conversation

ghostoy
Copy link
Contributor

@ghostoy ghostoy commented Jul 27, 2023

Checklist
  • npm test passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines
Affected core subsystem(s)

core

Description of change

允许HttpClient使用所有HTTP Method,而不仅限于GET和POST

@codecov-commenter
Copy link

codecov-commenter commented Jul 27, 2023

Codecov Report

Patch coverage: 100.00% and project coverage change: -0.15% ⚠️

Comparison is base (2d93592) 81.78% compared to head (1ecf674) 81.63%.

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3110      +/-   ##
==========================================
- Coverage   81.78%   81.63%   -0.15%     
==========================================
  Files         437      437              
  Lines       15918    15918              
  Branches     3769     3769              
==========================================
- Hits        13018    12995      -23     
- Misses       2631     2649      +18     
- Partials      269      274       +5     
Files Changed Coverage Δ
packages/core/src/util/httpclient.ts 95.52% <100.00%> (ø)

... and 3 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@czy88840616 czy88840616 added the pr: new feature This PR adds a new API or behavior. label Jul 27, 2023
@czy88840616 czy88840616 added this to the 3.12 milestone Jul 30, 2023
@czy88840616 czy88840616 merged commit b081880 into midwayjs:main Aug 13, 2023
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr: new feature This PR adds a new API or behavior.
Development

Successfully merging this pull request may close these issues.

None yet

3 participants