Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add ctx.forward api #3133

Merged
merged 1 commit into from Aug 13, 2023
Merged

feat: add ctx.forward api #3133

merged 1 commit into from Aug 13, 2023

Conversation

czy88840616
Copy link
Member

Checklist
  • npm test passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines
Affected core subsystem(s)
Description of change

@czy88840616 czy88840616 added the pr: new feature This PR adds a new API or behavior. label Aug 2, 2023
@czy88840616
Copy link
Member Author

#3121

@waitingsong
Copy link
Member

直接调用?

@codecov-commenter
Copy link

codecov-commenter commented Aug 2, 2023

Codecov Report

Patch coverage: 100.00% and project coverage change: +0.03% 🎉

Comparison is base (c6d8317) 81.83% compared to head (4f0521f) 81.87%.

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3133      +/-   ##
==========================================
+ Coverage   81.83%   81.87%   +0.03%     
==========================================
  Files         438      438              
  Lines       15936    15960      +24     
  Branches     3773     3781       +8     
==========================================
+ Hits        13042    13068      +26     
+ Misses       2626     2624       -2     
  Partials      268      268              
Files Changed Coverage Δ
packages/web-koa/src/framework.ts 79.50% <100.00%> (+2.44%) ⬆️
packages/web/app/extend/context.js 85.29% <100.00%> (+7.03%) ⬆️

... and 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@czy88840616
Copy link
Member Author

@waitingsong 直接调也可以,本质是一样的,就是要互相依赖了,对标 java 的话统一 api 就行了。

@czy88840616 czy88840616 added this to the 3.12.x milestone Aug 2, 2023
@czy88840616 czy88840616 merged commit 0fc30f6 into main Aug 13, 2023
7 checks passed
@czy88840616 czy88840616 deleted the support_forward branch August 13, 2023 04:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr: new feature This PR adds a new API or behavior.
Development

Successfully merging this pull request may close these issues.

None yet

3 participants