Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add main framework missing error #3462

Merged
merged 2 commits into from Dec 5, 2023

Conversation

czy88840616
Copy link
Member

Checklist
  • npm test passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines
Affected core subsystem(s)
Description of change

@czy88840616 czy88840616 added the pr: polish This PR adds a very minor behavior improvement that users will enjoy. label Nov 29, 2023
@codecov-commenter
Copy link

codecov-commenter commented Nov 29, 2023

Codecov Report

Attention: 13 lines in your changes are missing coverage. Please review.

Comparison is base (499a5c3) 84.59% compared to head (e2b64a6) 84.56%.

Files Patch % Lines
packages/bootstrap/src/bootstrap.ts 20.00% 8 Missing ⚠️
packages/core/src/error/framework.ts 50.00% 5 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3462      +/-   ##
==========================================
- Coverage   84.59%   84.56%   -0.03%     
==========================================
  Files         478      478              
  Lines       45475    45495      +20     
  Branches     5420     5421       +1     
==========================================
+ Hits        38469    38475       +6     
- Misses       6968     6982      +14     
  Partials       38       38              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@czy88840616 czy88840616 added this to the 3.14.x milestone Dec 3, 2023
@czy88840616 czy88840616 merged commit 1e7e45a into main Dec 5, 2023
6 checks passed
@czy88840616 czy88840616 deleted the add_main_framework_missing_error branch December 5, 2023 16:10
@czy88840616 czy88840616 removed this from the 3.14.x milestone Dec 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr: polish This PR adds a very minor behavior improvement that users will enjoy.
Development

Successfully merging this pull request may close these issues.

None yet

2 participants