Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support heartbeat for ws #3582

Merged
merged 1 commit into from Jan 20, 2024
Merged

feat: support heartbeat for ws #3582

merged 1 commit into from Jan 20, 2024

Conversation

czy88840616
Copy link
Member

Checklist
  • npm test passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines
Affected core subsystem(s)
Description of change

@czy88840616 czy88840616 added pr: new feature This PR adds a new API or behavior. pr: polish This PR adds a very minor behavior improvement that users will enjoy. and removed pr: new feature This PR adds a new API or behavior. labels Jan 20, 2024
@codecov-commenter
Copy link

Codecov Report

Attention: 5 lines in your changes are missing coverage. Please review.

Comparison is base (8a33d05) 84.45% compared to head (fdcefc3) 84.45%.
Report is 4 commits behind head on main.

Files Patch % Lines
packages/ws/src/framework.ts 82.14% 5 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #3582   +/-   ##
=======================================
  Coverage   84.45%   84.45%           
=======================================
  Files         491      491           
  Lines       46686    46725   +39     
  Branches     5576     5583    +7     
=======================================
+ Hits        39428    39463   +35     
- Misses       7217     7221    +4     
  Partials       41       41           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@czy88840616 czy88840616 merged commit d70cd65 into main Jan 20, 2024
6 checks passed
@czy88840616 czy88840616 deleted the support_ws_heartbeat branch January 20, 2024 06:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr: polish This PR adds a very minor behavior improvement that users will enjoy.
Development

Successfully merging this pull request may close these issues.

None yet

2 participants