Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: remove typings from the cron module since it includes its own types #3786

Merged
merged 1 commit into from Apr 14, 2024
Merged

fix: remove typings from the cron module since it includes its own types #3786

merged 1 commit into from Apr 14, 2024

Conversation

czy88840616
Copy link
Member

@czy88840616 czy88840616 commented Apr 14, 2024 •
edited

We try to remove @types/cron.

Checklist
  • npm test passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines
Affected core subsystem(s)
Description of change

@czy88840616 czy88840616 changed the title fix: remove typings from the cron module since it includes its own ty… fix: remove typings from the cron module since it includes its own types Apr 14, 2024
@czy88840616 czy88840616 added the pr: bug fix This PR fixes a bug in a past release. label Apr 14, 2024
@czy88840616 czy88840616 merged commit 9a884a7 into main Apr 14, 2024
7 checks passed
@czy88840616 czy88840616 deleted the remove_cron_typings branch April 14, 2024 15:45
czy88840616 added a commit that referenced this pull request May 6, 2024
@czy88840616
fix: remove typings from the cron module since it includes its own ty…
869ae70 
…pes. (#3786)

(cherry picked from commit 9a884a7)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
pr: bug fix This PR fixes a bug in a past release.
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@czy88840616