fix: make request.query writeable #3842
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
czy88840616
added
pr: polish
|
zookeeper image 看起来有问题，先发版后修 |
pandaApe
reviewed
May 9, 2024
|
|
||
| @Get('/set_query') | ||
| async setQuery(ctx) { | ||
| ctx.query = { a: 1 }; |
There was a problem hiding this comment.
ctx.request.query = query
是不是要取reqeust里的query?
目前这种，跟之前的行为不一样，导致我这边parma validation 过不了
There was a problem hiding this comment.
ctx.query 实际会调用 ctx.request.query
czy88840616
added a commit
that referenced
this pull request
May 10, 2024
(cherry picked from commit 9b13409)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
npm testpassesAffected core subsystem(s)
Description of change